D5139: store: introduce _matchtrackedpath() and use it to filter store files

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Mon Nov 5 16:08:41 UTC 2018


durin42 added inline comments.

INLINE COMMENTS

> store.py:39
> +    elif path.startswith('meta/'):
> +        return matcher.visitdir(path[len('meta/'):-len('/00manifest.i')] or '.')
> +

Please follow up with a patch that raises ProgrammingError at the end of this function - right now you just magically return False if you don't recognize the path, which feels dangerous.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5139

To: pulkit, durin42, #hg-reviewers
Cc: mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list