D5229: runbgcommand: import concerns about creationflags on Windows from D1701
lothiraldan (Boris Feld)
phabricator at mercurial-scm.org
Tue Nov 6 10:54:36 UTC 2018
lothiraldan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I don't have the need anymore for the change in https://phab.mercurial-scm.org/D1701 nor the time to
investigate the changes on all supported Windows platforms.
I import the stuff I learned on https://phab.mercurial-scm.org/D1701 in the `runbgcommand` so the next people
working on it can starts from there.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5229
AFFECTED FILES
mercurial/utils/procutil.py
CHANGE DETAILS
diff --git a/mercurial/utils/procutil.py b/mercurial/utils/procutil.py
--- a/mercurial/utils/procutil.py
+++ b/mercurial/utils/procutil.py
@@ -474,6 +474,9 @@
# https://msdn.microsoft.com/en-us/library/windows/desktop/ms684863.aspx
# No stdlib constant exists for this value
DETACHED_PROCESS = 0x00000008
+ # Following creation flags might create a console GUI window.
+ # Using subprocess.CREATE_NEW_CONSOLE might helps.
+ # See https://phab.mercurial-scm.org/D1701 for discussion
_creationflags = DETACHED_PROCESS | subprocess.CREATE_NEW_PROCESS_GROUP
def runbgcommand(script, env, shell=False, stdout=None, stderr=None):
To: lothiraldan, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list