D5139: store: introduce _matchtrackedpath() and use it to filter store files

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Thu Nov 8 07:12:40 EST 2018


yuja added a comment.


  Can you add the following tests?
  
  - encoded filename differs from the original name (e.g. uppercase letter)
  - fncache disabled, but encodedstore is used
  
  >   def datafiles(self, matcher=None):
  >       for a, b, size in super(encodedstore, self).datafiles():
  > 
  > +            if not _matchtrackedpath(a, matcher):
  >  +                continue
  > 
  >   try:
  >       a = decodefilename(a)
  
  I'm pretty sure it's wrong to pass in an encoded filename to matcher.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5139

To: pulkit, durin42, #hg-reviewers
Cc: yuja, mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list