D5257: manifest: also reject obviously-too-short lines when parsing lines

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Nov 13 06:38:22 EST 2018


yuja added a comment.


  > +		if ((next - data) < 22) {
  >  +			/* We should have at least 22 bytes in a line:
  >  +			   1 byte filename
  >  +			   1 NUL
  >  +			   20 bytes of hash
  
  Queued, but I think it should be **40** bytes of hexadecimal hash.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5257

To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list