D5064: style: run black on a subset of mercurial

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Nov 14 01:20:51 UTC 2018


indygreg added a comment.


  Where do we stand on the intent to mass reformat the code base?
  
  I'm not super thrilled at some of black's decisions (like using double quotes for all strings and merging imports into the same line which leads to excessive code churn later). But the exact style doesn't matter as much as having it be consistent. So I'm willing to go with black if we feel it's the best tool for the job. I'm not sure what the alternatives are these days.

INLINE COMMENTS

> mergeutil.py:18
> +        raise error.Abort(
> +            _("unresolved merge conflicts " "(see 'hg help resolve')")
> +        )

I'm surprised by this result. I'd like to think the reformatting tool would be smarter than this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5064

To: mjpieters, indygreg, durin42, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list