[PATCH 04 of 10 V2] sparse-revlog: add a `index_get_start` function in C

Yuya Nishihara yuya at tcha.org
Fri Nov 16 07:11:59 EST 2018


On Thu, 15 Nov 2018 11:38:42 +0100, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld <boris.feld at octobus.net>
> # Date 1541785348 -3600
> #      Fri Nov 09 18:42:28 2018 +0100
> # Node ID f78fcec5ba387ff17ace7ca99294a90c7ba92387
> # Parent  20e272f4f88c761b61556b4a4db08890fac21f56
> # EXP-Topic sparse-perf
> # Available At https://bitbucket.org/octobus/mercurial-devel/
> #              hg pull https://bitbucket.org/octobus/mercurial-devel/ -r f78fcec5ba38
> sparse-revlog: add a `index_get_start` function in C
> 
> We are about to implement a native version of `slicechunktodensity`. For
> clarity, we introduce the helper functions first. This new function provides
> an efficient way to retrieve some of the information needed by
> `slicechunktodensity`.
> 
> diff --git a/mercurial/cext/revlog.c b/mercurial/cext/revlog.c
> --- a/mercurial/cext/revlog.c
> +++ b/mercurial/cext/revlog.c
> @@ -185,6 +185,27 @@ static inline int index_get_parents(inde
>  	return 0;
>  }
>  
> +static inline uint64_t index_get_start(indexObject *self, Py_ssize_t rev)
> +{
> +	uint64_t offset;
> +	if (rev >= self->length) {
> +		PyObject *tuple =
> +		    PyList_GET_ITEM(self->added, rev - self->length);
> +		offset = (uint64_t)PyInt_AS_LONG(PyTuple_GET_ITEM(tuple, 0));

Can you update this and the next patch to use pylong_to_long(). PyInt_AS_LONG()
is brain damaged on Python 3.


More information about the Mercurial-devel mailing list