D5269: tests: sniff for /usr/local/bin/gmake and use it in test-fuzz-targets.t

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Sat Nov 17 21:56:41 EST 2018


yuja added a comment.


  (resend)
  
  >> +  $ if [ -x /usr/local/bin/gmake ] ; then
  >  > +  >     MAKE=gmake
  > 
  > Isn't this assuming that /usr/local/bin is in $PATH?  IOW, shouldn't this
  >  assignment be:
  > 
  >   	MAKE=/usr/local/bin/gmake
  
  Perhaps, `type` or `which` can be used instead. `gmake` should be in PATH
  if it's supposed to be used.
  
  https://stackoverflow.com/a/39983421/10435339

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5269

To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list