D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Tue Nov 20 11:55:58 EST 2018


pulkit added a comment.


  In https://phab.mercurial-scm.org/D5287#78759, @yuja wrote:
  
  > > diff --git a/hgext/remotefilelog/basepack.py b/hgext/remotefilelog/basepack.py
  > > 
  > > - a/hgext/remotefilelog/basepack.py +++ b/hgext/remotefilelog/basepack.py @@ -10,6 +10,7 @@
  > > 
  > >   from mercurial.i18n import _ from mercurial import ( +    node,
  >
  > hgext/remotefilelog/basepack.py:472: import 'node' from line 12 shadowed by loop variable
  
  
  Looks like a False positive/negative.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5287

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list