D5287: py3: use node.hex(m.digest()) instead of m.hexdigest()

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Nov 21 07:41:53 EST 2018


yuja added a comment.


  >   > hgext/remotefilelog/basepack.py:472: import 'node' from line 12 shadowed by loop variable
  >   
  >   Looks like a False positive/negative.
  
  Might be, but it's better to not shadow global names by local ones.
  
  Queued, thanks.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5287

To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list