D5288: tests: make test-alias.t pass with re2

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Wed Nov 21 09:22:42 EST 2018


yuja added a comment.


  >   Thanks. FWIW, re2 options allow to choose an encoding which is latin1 or utf8 (https://github.com/google/re2/blob/master/re2/re2.h#L609). Presumably latin1 means that "." matches a byte, which would seem more compatible with re, but python bindings don't provide the ability to choose this encoding.
  
  Indeed. We could pass in a fat unicode array (i.e. each byte as latin-1 char)
  to re2, but that would sacrifice the performance.
  
  Thanks for the info.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5288

To: valentin.gatienbaron, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list