[PATCH] blackbox: add configitem for format of log timestamps

Martin von Zweigbergk martinvonz at google.com
Wed Nov 21 11:37:22 EST 2018


On Wed, Nov 21, 2018 at 8:32 AM MATTHEW DEVORE <matvore at comcast.net> wrote:

> Ping. Did you have any trouble applying this updated patch? This one
> should not have any mangled spaces.
>

This was queued as https://www.mercurial-scm.org/repo/hg/rev/25f1c7bd649d
(Yuya replied to you at Oct 24, 2018, 4:15 AM Pacific time).


> > On October 23, 2018 at 1:49 PM Matthew DeVore wrote:
> >
> >
> > From: Matt DeVore
> >
> > My e-mail client was mangling spaces, which is why you couldn't apply
> the
> > patch earlier. I'm sending this again with a different tool and e-mail
> address.
> >
> --------------------------------------------------------------------------------
>
> >
> > # HG changeset patch
> > # User Matt DeVore
> > # Date 1539816481 25200
> > # Wed Oct 17 15:48:01 2018 -0700
> > # Node ID 13c2fe6d3b30a743daa1984404a70ed769779d11
> > # Parent a0e7fa019290d5348c4a83f6b287f2612d645025
> > blackbox: add configitem for format of log timestamps
> >
> > Sometimes blackbox logs are used to report performance problems, but the
> > timestamps are only at second granularity, so often the timings have to
> > stated separately by the reporter. This is inconvenient and error-prone,
> > so I would like to include %f in the date format. This patch makes that
> > possible.
> >
> > diff --git a/hgext/blackbox.py b/hgext/blackbox.py
> > --- a/hgext/blackbox.py
> > +++ b/hgext/blackbox.py
> > @@ -33,6 +33,11 @@ Examples::
> > # rotate up to N log files when the current one gets too big
> > maxfiles = 3
> >
> > + [blackbox]
> > + # Include nanoseconds in log entries with %f (see Python function
> > + # datetime.datetime.strftime)
> > + date-format = '%Y-%m-%d @ %H:%M:%S.%f'
> > +
> > """
> >
> > from __future__ import absolute_import
> > @@ -82,6 +87,9 @@ configitem('blackbox', 'maxfiles',
> > configitem('blackbox', 'track',
> > default=lambda: ['*'],
> > )
> > +configitem('blackbox', 'date-format',
> > + default='%Y/%m/%d %H:%M:%S',
> > +)
> >
> > lastui = None
> >
> > @@ -169,7 +177,9 @@ def wrapui(ui):
> > return
> > ui._bbinlog = True
> > default = self.configdate('devel', 'default-date')
> > - date = dateutil.datestr(default, '%Y/%m/%d %H:%M:%S')
> > + format = ui.config('blackbox', 'date-format')
> > + date = dateutil.datestr(default,
> > + ui.config('blackbox', 'date-format'))
> > user = procutil.getuser()
> > pid = '%d' % procutil.getpid()
> > formattedmsg = msg[0] % msg[1:]
> > diff --git a/tests/test-blackbox.t b/tests/test-blackbox.t
> > --- a/tests/test-blackbox.t
> > +++ b/tests/test-blackbox.t
> > @@ -82,6 +82,16 @@ recursive aliases work correctly
> > 1970/01/01 00:00:00 bob @0000000000000000000000000000000000000000
> (5000)> so-confusing exited 0 after * seconds (glob)
> > 1970/01/01 00:00:00 bob @0000000000000000000000000000000000000000
> (5000)> blackbox
> >
> > +custom date format
> > + $ rm ./.hg/blackbox.log
> > + $ hg --config blackbox.date-format='%Y-%m-%d @ %H:%M:%S' \
> > + > --config devel.default-date='1334347993 0' --traceback status
> > + A a
> > + $ hg blackbox
> > + 2012-04-13 @ 20:13:13 bob @0000000000000000000000000000000000000000
> (5000)> --config 'blackbox.date-format=%Y-%m-%d @ %H:%M:%S' --config
> 'devel.default-date=1334347993 0' --traceback status
> > + 2012-04-13 @ 20:13:13 bob @0000000000000000000000000000000000000000
> (5000)> --config 'blackbox.date-format=%Y-%m-%d @ %H:%M:%S' --config
> 'devel.default-date=1334347993 0' --traceback status exited 0 after *
> seconds (glob)
> > + 1970/01/01 00:00:00 bob @0000000000000000000000000000000000000000
> (5000)> blackbox
> > +
> > incoming change tracking
> >
> > create two heads to verify that we only see one change in the log later
> >
> >
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20181121/37e59202/attachment.html>


More information about the Mercurial-devel mailing list