D5291: branchmap: build the revbranchcache._namesreverse() only when required
yuja (Yuya Nishihara)
phabricator at mercurial-scm.org
Thu Nov 22 08:32:21 EST 2018
yuja added a comment.
> > Maybe _namesreverse can be a propertycache, instead of duplicating it.
> > `del self.__dict__[r'...']` can be used to discard the cache.
>
> Hm, I am not sure if I feel good about doing `del self.__dict__[r'...']` thing.
It's pretty common in Mercurial codebase. That said, I found a better way.
`util.clearcachedproperty(self, '...')`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5291
To: pulkit, #hg-reviewers
Cc: yuja, mercurial-devel
More information about the Mercurial-devel
mailing list