D5299: phabricator: fallback reading arcanist config files
philpep (Philippe Pepiot)
phabricator at mercurial-scm.org
Fri Nov 23 12:15:27 EST 2018
philpep added inline comments.
INLINE COMMENTS
> phabricator.py:201
> + if conduit_uri is not None:
> + token = config.get('hosts', {}).get(conduit_uri, {}).get('token')
> + url = conduit_uri.rstrip('/api/')
HINT: This doesn't work for current mercurial config because "arc install-certificates" add a trailing "/" to conduit_uri and our .arcconfig doesn't have this trailing slash.
Any idea how to handle this properly ?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5299
To: philpep, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list