D5299: phabricator: fallback reading arcanist config files

[mharbison72 (Matt Harbison)]

mharbison72 added inline comments.

INLINE COMMENTS

> phabricator.py:179
> +    """
> +    if os.name == 'nt':
> +        paths = [

pycompat.iswindows

> phabricator.py:181
> +        paths = [
> +            os.path.join(os.environ['ProgramData'],
> +                         'Phabricator',

I think there’s something for environment variables in encoding (or maybe procutil- I don’t have the code in front of me).

Also, is there a way to use vfs here?  I think we’re trying to avoid direct os.path usage.

https://www.mercurial-scm.org/wiki/WindowsUTF8Plan

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5299

To: philpep, #hg-reviewers
Cc: mharbison72, mercurial-devel