[PATCH] tests: disable remotefilelog on Windows

Yuya Nishihara yuya at tcha.org
Mon Nov 26 06:37:16 EST 2018


On Sat, 24 Nov 2018 23:17:26 -0500, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1543086662 18000
> #      Sat Nov 24 14:11:02 2018 -0500
> # Node ID 99e50fb3ffc6fa3d5e81427c69e5280c84254ab0
> # Parent  1f9de5636e5f7f4bfe2d3fb8c5dde543a1870161
> tests: disable remotefilelog on Windows
> 
> I've spent a non trivial amount of time trying to eliminate the test errors, but
> it's looking like this is pretty dependent on Unix support.  For example, there
> are attempts to delete open files, and uses of threads that report I/O attempts
> on closed files.  (Maybe this is a race condition?  Don't we usually use
> processes as workers on Windows?)
> 
> In any event, I don't want real new errors elsewhere to be masked by these known
> problems.
> 
> For some reason $CACHEDIR is reported as missing in test-remotefilelog-repack.t,
> but it actually exists in the hgcloneshallow call inside
> shallowutil.mkstickygroupdir().  By the time the process exits, it's gone.  I
> don't see it being removed by code that calls 'rmdir' or 'remove' in the
> extension itself.

Queued, thanks.

Should we make remotefilelog.uisetup() abort if enabled on Windows?


More information about the Mercurial-devel mailing list