D5308: store: don't pass 'atomictemp=True' while appending to fncache
Yuya Nishihara
yuya at tcha.org
Tue Nov 27 08:34:44 EST 2018
> --- a/mercurial/store.py
> +++ b/mercurial/store.py
> @@ -486,7 +486,7 @@
> if self.addls:
> # if we have just new entries, let's append them to the fncache
> tr.addbackup('fncache')
> - fp = self.vfs('fncache', mode='ab', atomictemp=True)
> + fp = self.vfs('fncache', mode='ab')
Ah, no. addbackup() creates hardlink, which means fncache can't be updated in
place. Also, the reader wouldn't handle partially-written fncache well.
More information about the Mercurial-devel
mailing list