D5064: style: run black on a subset of mercurial

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Tue Nov 27 10:49:21 EST 2018


durin42 added a comment.


  In https://phab.mercurial-scm.org/D5064#78780, @mjpieters wrote:
  
  > In https://phab.mercurial-scm.org/D5064#78545, @av6 wrote:
  >
  > > I look at the changes and see nitpicks at best. On the one hand, black proved better than any linter that we can already write consistent code. On the other, if black were a linter... I'd switch to flake8, which at least is configurable <https://www.mercurial-scm.org/repo/evolve/file/tip/setup.cfg#l1>.
  >
  >
  > The whole **point** of black is that it is not configurable. Configurable means you still have to argue about style and decide on a configuration.
  
  
  Yep. I find I care less about style decisions when the computer is able to make them for me: eg I prefer ' to ", but since black can fix that and I don't have to type the " myself, I don't really care.
  
  Does anyone strongly object, or do we want to embrace black and the formatting changes it implies?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5064

To: mjpieters, indygreg, durin42, #hg-reviewers
Cc: av6, mercurial-devel


More information about the Mercurial-devel mailing list