Auto-formatting code with black - object now if you have a strong opinion

[Pulkit Goyal]

On Tue, Nov 27, 2018 at 7:10 PM Augie Fackler <raf at durin42.com> wrote:

>
>
> > On Nov 27, 2018, at 11:09, Pulkit Goyal <7895pulkit at gmail.com> wrote:
> >
> > I am +1 on using black.
> >
> > Adding to what Augie said, we plan to preserve the annotate history by
> commiting the changes with something like "# skip-blame" in commit message.
> We can then skip those revisions while annotating using the `--skip` flag
> of `hg annotate` which accepts a revset, something like `hg annotate --skip
> "desc('# skip-blame')"`.
> >
> > Maybe we should use "# skip-blame black-changes" to mark those changes
> as black specific and to differentiate between py3 and black changes. (We
> already use "# skip-blame" for py3 related trivial changes.)
>
> Indeed. Note that if we do the black transition, we should probably also
> do the mass-addition of b prefixes on our string literals at the same time
> (in a separate commit, obviously) so that people only have painful rebases
> once and not twice.
>

If nobody opposes black formatting, are we going to do that as a single
commit or a list of commits with a commit for each file? I prefer per-file
as that will be easy to review. but that will lead to lots of commits. :(
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20181127/b699f24c/attachment.html>