[PATCH 2 of 2] remotefilelog: prevent this extension from loading on Windows

Yuya Nishihara yuya at tcha.org
Thu Nov 29 08:18:21 EST 2018


On Thu, 29 Nov 2018 08:08:06 -0500, Augie Fackler wrote:
> On Thu, Nov 29, 2018, 08:03 Matt Harbison <mharbison72 at gmail.com wrote:
> 
> >
> > > On Nov 29, 2018, at 6:24 AM, Yuya Nishihara <yuya at tcha.org> wrote:
> > >
> > >> On Wed, 28 Nov 2018 18:41:05 -0500, Matt Harbison wrote:
> > >>
> > >>>> On Nov 28, 2018, at 1:59 PM, Augie Fackler <raf at durin42.com> wrote:
> > >>>>
> > >>>> On Nov 27, 2018, at 22:46, Matt Harbison <mharbison72 at gmail.com>
> > wrote:
> > >>>>
> > >>>> # HG changeset patch
> > >>>> # User Matt Harbison <matt_harbison at yahoo.com>
> > >>>> # Date 1543376352 18000
> > >>>> #      Tue Nov 27 22:39:12 2018 -0500
> > >>>> # Node ID aac9ae9f512f53a907dc799d2d6050931001e6e1
> > >>>> # Parent  c743bb1c19513a61925ce4663d33323aea7016cc
> > >>>> remotefilelog: prevent this extension from loading on Windows
> > >>>
> > >>> Hm, I have *vivid* memories of speaking up earlier, but I must not
> > have sent it to the list. Fail on my part. Anyway: I *know* remotefilelog
> > works on Windows. I'll probably tackle getting the tests to pass since they
> > don't, but I'd appreciate it if we could leave RFL working there even if we
> > can't test it.
> > >>
> > >> I’m fine with dropping this one.  I was going to suggest to Yuya that I
> > would wait on this a bit in case anybody wanted to try to work on it.  But,
> > I figured I would forget to follow up, and I was here anyway.
> > >
> > > Okay, dropped these. We should backout 0800d9e6e216 to re-enable the
> > failing
> > > tests. Otherwise, no one would fix them.
> >
> > I get that, but I’d like to leave the tests skipped so no other problems
> > creep in.  They’ve been broken for several weeks now without getting much
> > attention, probably because something is often broken on Windows.
> >
> 
> I agree. I'll work on the tests anyway, and I don't want them hiding good
> signal on Windows.

Can't we blacklist them on the buildbot then?

#require is hard requirement, which make not possible to run the remotefilelog
tests on Windows.


More information about the Mercurial-devel mailing list