D1694: debugcommands: replace opts.get('foo') by opts['foo']

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Nov 30 16:37:38 UTC 2018


pulkit added a comment.


  In https://phab.mercurial-scm.org/D1694#29072, @yuja wrote:
  
  >   Sometimes we do the reverse change for ease of calling command function as a plain function.
  
  
  Just for record, today I hit the problem where some command is using `opts['']` instead of `opts.get()` and I was trying to command function as plain function leading me to KeyError.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D1694

To: martinvonz, #hg-reviewers
Cc: pulkit, durin42, yuja, mercurial-devel


More information about the Mercurial-devel mailing list