D4786: narrow: factor out logic to create cg while widening into separate fn

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Oct 1 06:27:21 UTC 2018


martinvonz added inline comments.

INLINE COMMENTS

> narrowbundle2.py:54
>  
> +def widen_changegroup(repo, diffmatcher, common, cgversion, source):
> +    """generates changegroup for widening a narrow clone

Do you plan to add support for ellipses to this too? I don't know if you need that feature, but I think the coming wire protocol command should eventually gain support for ellipsis nodes. Do you think a TODO about that makes sense? (I imagine it requires including the "known" set if the local repo has the ellipses requirement.)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4786

To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list