D4812: narrow: pass old includes and excludes to _widen()

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Oct 1 07:08:40 UTC 2018


martinvonz added inline comments.

INLINE COMMENTS

> narrowcommands.py:251-252
>  
> -def _widen(ui, repo, remote, commoninc, newincludes, newexcludes):
> +def _widen(ui, repo, remote, commoninc, newincludes, newexcludes,
> +           oldincludes, oldexcludes):
>      newmatch = narrowspec.match(repo.root, newincludes, newexcludes)

nit: Can you put them before their `new*` counterparts? That's the order used elsewhere in this file (and is probably generally more common).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4812

To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list