D4787: narrow: pass 'narrow_widen' as source while generating changegroup

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Mon Oct 1 10:59:31 EDT 2018


pulkit added a comment.


  In https://phab.mercurial-scm.org/D4787#72712, @martinvonz wrote:
  
  > > Although this is called as a part of exchange.pull(), we don't want other
  > >  extensions to wrap this pull call because it's not a normal pull and it's
  > >  widening.
  >
  > I don't follow this. How does this prevent extensions from wrapping the pull? Do you mean that extensions that inspect the `source` parameter should not treat it like a normal pull? The `source` parameter also seems to be passed to hooks, btw (it probably makes sense to differentiate widening from pulling there too).
  
  
  Yes, I looked into the code where `source` parameter is used and it says the extension requires it. I think wrapping pull sounds to generic, I will improve the commit description. Thanks!

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4787

To: pulkit, durin42, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list