D4785: streamclone: pass includes and excludes to fn generating clones

[indygreg (Gregory Szorc)]

indygreg requested changes to this revision.
indygreg added a comment.
This revision now requires changes to proceed.


  I'm +1 on the direction of this series.
  
  I think we should make the feature stream clone version 2 only, as it requires client-side features and clients will presumably be using stream clone version 2. So supporting version 1 stream clones feels like avoidable complexity.
  
  We may also want to make server advertisement of the capability conditional on a value in `repo.features`. Then we can have revlog-based repos add that feature in `localrepo.makefilestorage()`. This is because not all storage backends will support narrow stream clone and I think it is something that a storage backend should opt into.
  
  It may also help to reorder the series so the `streamclone.py` changes come before the wire protocol bits, as they are less controversial and could be committed earlier.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4785

To: pulkit, durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel