D4713: largefiles: automatically load largefiles extension when required (BC)
mharbison72 (Matt Harbison)
phabricator at mercurial-scm.org
Tue Oct 2 01:22:06 EDT 2018
mharbison72 added a comment.
In https://phab.mercurial-scm.org/D4713#72604, @yuja wrote:
> > 1. Map of requirements to list of extensions to load automatically when
> > 2. requirement is present. autoextensions = { + b'largefiles': [b'largefiles'], b'lfs': [b'lfs'], }
>
> Can we add some warnings here? The largefiles is IMHO one of the most buggy
> extensions, and loading it has a side effect (e.g. fsmonitor is disabled.)
> It shouldn't be silently loaded into the process.
I get what you’re thinking, but maybe a debug message is better than a warning, even though it’s less visible. I’m concerned about every invocation being unnecessarily noisy now that .hg/hgrc isn’t updated, and noise on stderr triggers that thgw.exe dialog when UAC is enabled. OTOH, updating the hgrc with this would make for a quick and dirty one shot warning.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4713
To: indygreg, #hg-reviewers
Cc: mharbison72, yuja, mercurial-devel
More information about the Mercurial-devel
mailing list