D4819: identify: only query remote bookmarks if needed

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Tue Oct 2 07:54:21 EDT 2018


yuja added a comment.


  > +        bmscache = [None]
  > 
  >   def getbms():
  > 
  > +            if bmscache[0] is not None:
  >  +                return bmscache[0]
  
  Looks good, but I think `getbms()` can be a `@util.cachefunc`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4819

To: valentin.gatienbaron, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list