D4846: narrow: avoid overwriting a variable

[martinvonz (Martin von Zweigbergk)]

martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I don't like to overwrite variables, especially not with a different
  type (because it makes it harder to explain what the variable is for,
  and, therefore, to name it well).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4846

AFFECTED FILES
  hgext/narrow/narrowbundle2.py

CHANGE DETAILS

diff --git a/hgext/narrow/narrowbundle2.py b/hgext/narrow/narrowbundle2.py
--- a/hgext/narrow/narrowbundle2.py
+++ b/hgext/narrow/narrowbundle2.py
@@ -67,11 +67,10 @@
     """
     # XXX: This patch will start sending bundle2 after couple of patches when
     # called from the wireprotocol command
-    common = repo.revs("::%ln", common)
     commonnodes = set()
     cl = repo.changelog
-    for c in common:
-        commonnodes.add(cl.node(c))
+    for r in repo.revs("::%ln", common):
+        commonnodes.add(cl.node(r))
     if commonnodes:
         # XXX: we should only send the filelogs (and treemanifest). user
         # already has the changelog and manifest



To: martinvonz, durin42, #hg-reviewers
Cc: mercurial-devel