[PATCH 11 of 13] obsolete: allow multiple predecessors in createmarkers

[Martin von Zweigbergk]

On Wed, Oct 3, 2018, 06:36 Boris FELD <boris.feld at octobus.net> wrote:

> On 30/09/2018 14:49, Yuya Nishihara wrote:
> > On Thu, 27 Sep 2018 19:08:43 +0200, Boris Feld wrote:
> >> # HG changeset patch
> >> # User Boris Feld <boris.feld at octobus.net>
> >> # Date 1537620033 -7200
> >> #      Sat Sep 22 14:40:33 2018 +0200
> >> # Node ID 84585c803b4156717b397e3753fc59e9dc3785d8
> >> # Parent  b3bd71652d1258de723a667a6f1210a27b86b019
> >> # EXP-Topic trackfold
> >> # Available At https://bitbucket.org/octobus/mercurial-devel/
> >> #              hg pull https://bitbucket.org/octobus/mercurial-devel/
> -r 84585c803b41
> >> obsolete: allow multiple predecessors in createmarkers
> >> +            if 1 < len(predecessors) and len(rel[1]) != 1:
> > Really minor nit: I'm not a fan of Yoda conditions. Is it common in
> Python
> > folks?
> It's just an automatic habit of keeping "<" in ascending order with
> smaller on the left and higher on the right. Neither Pep8 nor static
> analysis tools have fought that habit so far.
>

I'm also not a fan. I might send a patch to remove it :)

> _______________________________________________
> > Mercurial-devel mailing list
> > Mercurial-devel at mercurial-scm.org
> > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20181003/a7ff1e70/attachment.html>