D4713: largefiles: automatically load largefiles extension when required (BC)

[yuja (Yuya Nishihara)]

yuja added a comment.


  >   The only data point I have is what I did, which was to only enable it on the command line when cloning.  The clone command modifying the local hgrc if necessary handled the rest.  I only started to do that because I got annoyed at how simply having it loaded could alter certain commands.  IDK if command line enabling was ever documented as the preferred alternative, but that's how I described it in https://phab.mercurial-scm.org/rHGe1dbe0b215ae137eec53ceb12440536d570a83d2.
  >   
  >   At this point, I can't recall specific issues with globally enabling, and they might be mostly fixed.  They definitely aren't all fixed.  That said, this implicit loading on demand seems roughly equivalent to the previous behavior, so I'm not sure that this would be any more surprising.  Repos on the command line would be isolated, but not with commandserver because of the global function wrapping.  But I'm guessing most people don't understand that about commandserver.
  
  IIUC, we would have to enable the largefiles extension once to clone the
  repo, but that's no longer needed. So you can enable the extension without
  hearing its name at all.
  
  Perhaps, a warning can be displayed when the non-core repository requirement
  is added?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4713

To: indygreg, #hg-reviewers
Cc: mharbison72, yuja, mercurial-devel