D4803: storageutil: extract most of emitrevisions() to standalone function

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Wed Oct 3 14:47:49 UTC 2018


durin42 requested changes to this revision.
durin42 added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> storageutil.py:266
> +
> +def emitrevisions(store, revs, resultcls, deltaparentfn, candeltafn,
> +                  rawsizefn, revdifffn, flagsfn, sendfulltext=False,

This is a huge step backwards for remotefilelog and friends: it's all defined in terms of revs, whereas emitrevisions (as copypasta-inducing as it was) was in terms of nodes. We need to do better.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4803

To: indygreg, #hg-reviewers, durin42
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list