D4797: storageutil: implement file identifier resolution method (BC)
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Oct 3 13:14:10 EDT 2018
martinvonz added a comment.
> "0" on an empty store now raises LookupError instead of returning nullid.
I haven't checked the code, but I suspect this was just a special case of interpreting "rl.lookup(len(rl))" as nullid. I thought I had fixed all those cases about a month ago when I made the index not behave like that (I made only -1 look up the nullid), but maybe I missed a case here.
> with the exception of partial hex node matching, we may want to consider changing revlog.lookup() as well
Maybe even without the exception? I thought we used partial nodeids only for debug commands and maybe we can move the partial matching to a higher level.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4797
To: indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list