D4860: repository: define and use revision flag constants

[indygreg (Gregory Szorc)]

indygreg added inline comments.

INLINE COMMENTS

> martinvonz wrote in changegroups.txt:139-142
> Add a TODO about removing this flag from the changegroup? Can be done in a followup. I'm also not sure if this is the right place for a TODO. Maybe it should be in repository.py?

You mean removing the single integer flags field from a future changegroup v4? TBH I'm not sure we'd want to do that: bitwise fields do work for what we're using them for. It's just that we need better definitions around what flags are in play. e.g. the server should advertise revision flags that may be sent and clients should check for compatibility *before* attempting to pull data. And we need to abstract the flags in code such that we're not passing wire protocol bit flags down to the storage layer for verbatim storage, as that constricts behavior of storage backends.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4860

To: indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel