D4939: logtoprocess: use new runbgcommand from procutil

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Thu Oct 11 09:35:09 EDT 2018


indygreg accepted this revision.
indygreg added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> logtoprocess.py:68
> -            subprocess.Popen(
> -                procutil.tonativestr(script),
> -                shell=True, env=procutil.tonativeenv(env), close_fds=True,

`tonativestr` is lost as part of the function port. Do we need it for Py3?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4939

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list