D4973: tests: use baseurl instead of advertisedbaseurl

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Oct 12 08:13:56 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The distinction matters for e.g. hosts behind load balancers. But for
  the test environment, it doesn't matter.
  
  For whatever reason, advertisedbaseurl is resolving to
  http://1.0.0.127.in-addr.arpa:$HGPORT on my MBP. This hostname fails
  to resolve, causing the test to fail. No clue what's up with that
  behavior.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4973

AFFECTED FILES
  tests/wireprotosimplecache.py

CHANGE DETAILS

diff --git a/tests/wireprotosimplecache.py b/tests/wireprotosimplecache.py
--- a/tests/wireprotosimplecache.py
+++ b/tests/wireprotosimplecache.py
@@ -127,7 +127,7 @@
             paths.append(b'simplecache')
             paths.append(self.key)
 
-            url = b'%s/%s' % (self.req.advertisedbaseurl, b'/'.join(paths))
+            url = b'%s/%s' % (self.req.baseurl, b'/'.join(paths))
 
             #url = b'http://example.com/%s' % self.key
             self.ui.log('simplecache', 'sending content redirect for %s to '



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list