D5005: tests: expand our coverage of errors in Python 3 for bad extensions

durin42 (Augie Fackler) phabricator at mercurial-scm.org
Fri Oct 12 16:53:44 UTC 2018


durin42 created this revision.
Herald added subscribers: mercurial-devel, mjpieters.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  What a mess.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5005

AFFECTED FILES
  tests/test-bad-extension.t

CHANGE DETAILS

diff --git a/tests/test-bad-extension.t b/tests/test-bad-extension.t
--- a/tests/test-bad-extension.t
+++ b/tests/test-bad-extension.t
@@ -51,15 +51,18 @@
 
 show traceback
 
-  $ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError'
+  $ hg -q help help --traceback 2>&1 | egrep ' extension|^Exception|Traceback|ImportError|ModuleNotFound'
   *** failed to import extension badext from $TESTTMP/badext.py: bit bucket overflow
   Traceback (most recent call last):
   Exception: bit bucket overflow
   *** failed to import extension badext2: No module named *badext2* (glob)
   Traceback (most recent call last):
   ImportError: No module named badext2 (no-py3k !)
+  ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
   Traceback (most recent call last): (py3k !)
+  ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
   Traceback (most recent call last): (py3k !)
+  ModuleNotFoundError: No module named 'badext2' (py3k !)
 
 names of extensions failed to load can be accessed via extensions.notloaded()
 
@@ -79,7 +82,7 @@
 
   $ (hg help help --traceback --debug --config devel.debug.extensions=yes 2>&1) \
   > | grep -v '^ ' \
-  > | egrep 'extension..[^p]|^Exception|Traceback|ImportError|not import'
+  > | egrep 'extension..[^p]|^Exception|Traceback|ImportError|not import|ModuleNotFound'
   debug.extensions: loading extensions
   debug.extensions: - processing 5 entries
   debug.extensions:   - loading extension: 'gpg'
@@ -100,14 +103,21 @@
   debug.extensions:     - could not import hgext.badext2 (No module named *badext2*): trying hgext3rd.badext2 (glob)
   Traceback (most recent call last):
   ImportError: No module named badext2 (no-py3k !)
+  ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
   debug.extensions:     - could not import hgext3rd.badext2 (No module named *badext2*): trying badext2 (glob)
   Traceback (most recent call last):
   ImportError: No module named badext2 (no-py3k !)
   Traceback (most recent call last): (py3k !)
+  ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
+  Traceback (most recent call last): (py3k !)
+  ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
   *** failed to import extension badext2: No module named *badext2* (glob)
   Traceback (most recent call last):
+  ModuleNotFoundError: No module named 'hgext.badext2' (py3k !)
   Traceback (most recent call last): (py3k !)
+  ModuleNotFoundError: No module named 'hgext3rd.badext2' (py3k !)
   Traceback (most recent call last): (py3k !)
+  ModuleNotFoundError: No module named 'badext2' (py3k !)
   ImportError: No module named badext2 (no-py3k !)
   debug.extensions: > loaded 2 extensions, total time * (glob)
   debug.extensions: - loading configtable attributes



To: durin42, #hg-reviewers
Cc: mjpieters, mercurial-devel


More information about the Mercurial-devel mailing list