D5011: py3: use write() instead of print()

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Oct 12 17:25:02 UTC 2018


indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Because print() expects str and we want to write bytes.
  
  There should be no functional changes as part of this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5011

AFFECTED FILES
  mercurial/lsprofcalltree.py

CHANGE DETAILS

diff --git a/mercurial/lsprofcalltree.py b/mercurial/lsprofcalltree.py
--- a/mercurial/lsprofcalltree.py
+++ b/mercurial/lsprofcalltree.py
@@ -10,7 +10,7 @@
 of the GNU General Public License, incorporated herein by reference.
 """
 
-from __future__ import absolute_import, print_function
+from __future__ import absolute_import
 
 def label(code):
     if isinstance(code, str):
@@ -27,7 +27,7 @@
 
     def output(self, out_file):
         self.out_file = out_file
-        print('events: Ticks', file=out_file)
+        out_file.write(b'events: Ticks\n')
         self._print_summary()
         for entry in self.data:
             self._entry(entry)
@@ -37,23 +37,24 @@
         for entry in self.data:
             totaltime = int(entry.totaltime * 1000)
             max_cost = max(max_cost, totaltime)
-        print('summary: %d' % max_cost, file=self.out_file)
+        self.out_file.write(b'summary: %d\n' % max_cost)
 
     def _entry(self, entry):
         out_file = self.out_file
 
         code = entry.code
         if isinstance(code, str):
-            print('fi=~', file=out_file)
+            out_file.write(b'fi=~\n')
         else:
-            print('fi=%s' % code.co_filename, file=out_file)
-        print('fn=%s' % label(code), file=out_file)
+            out_file.write(b'fi=%s\n' % code.co_filename)
+
+        out_file.write(b'fn=%s\n' % label(code))
 
         inlinetime = int(entry.inlinetime * 1000)
         if isinstance(code, str):
-            print('0 ', inlinetime, file=out_file)
+            out_file.write(b'0 %d\n' % inlinetime)
         else:
-            print('%d %d' % (code.co_firstlineno, inlinetime), file=out_file)
+            out_file.write(b'%d %d\n' % (code.co_firstlineno, inlinetime))
 
         # recursive calls are counted in entry.calls
         if entry.calls:
@@ -68,19 +69,20 @@
 
         for subentry in calls:
             self._subentry(lineno, subentry)
-        print(file=out_file)
+
+        out_file.write(b'\n')
 
     def _subentry(self, lineno, subentry):
         out_file = self.out_file
         code = subentry.code
-        print('cfn=%s' % label(code), file=out_file)
+        out_file.write(b'cfn=%s\n' % label(code))
         if isinstance(code, str):
-            print('cfi=~', file=out_file)
-            print('calls=%d 0' % subentry.callcount, file=out_file)
+            out_file.write(b'cfi=~\n')
+            out_file.write(b'calls=%d 0\n' % subentry.callcount)
         else:
-            print('cfi=%s' % code.co_filename, file=out_file)
-            print('calls=%d %d' % (
-                subentry.callcount, code.co_firstlineno), file=out_file)
+            out_file.write(b'cfi=%s\n' % code.co_filename)
+            out_file.write(b'calls=%d %d\n' % (
+                subentry.callcount, code.co_firstlineno))
 
         totaltime = int(subentry.totaltime * 1000)
-        print('%d %d' % (lineno, totaltime), file=out_file)
+        out_file.write(b'%d %d\n' % (lineno, totaltime))



To: indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list