D5002: extensions: fix up many many debug logs that use %r

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Fri Oct 12 13:31:29 EDT 2018


indygreg requested changes to this revision.
indygreg added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> extensions.py:178
>          return _extensions[shortname]
> -    log('  - loading extension: %r\n', shortname)
> +    log('  - loading extension: %r\n', pycompat.bytestr(shortname))
>      _extensions[shortname] = None

Can't we just switch to `%s`?

> extensions.py:181
> +    with util.timedcm('load extension %r',
> +                      pycompat.bytestr(shortname)) as stats:
>          mod = _importext(name, path, bind(_reportimporterror, ui))

Ditto.

> extensions.py:202-204
> +    log('    - invoking registered callbacks: %r\n',
> +        pycompat.bytestr(shortname))
> +    with util.timedcm('callbacks extension %r',

Ditto.

> extensions.py:258
>                      if name not in _disabledextensions:
> -                        log('  - skipping disabled extension: %r\n', name)
> +                        log('  - skipping disabled extension: %r\n',
> +                            pycompat.bytestr(name))

Ditto.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5002

To: durin42, #hg-reviewers, indygreg
Cc: indygreg, mercurial-devel


More information about the Mercurial-devel mailing list