D5026: py3: use '%s' instead of %r in hgext/convert/subversion.py
pulkit (Pulkit Goyal)
phabricator at mercurial-scm.org
Sat Oct 13 01:58:22 UTC 2018
pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Using '%r' on bytes in python 3 adds b'' prefixes to output which is bad. I
don't see a reason why we want to repr() the string here, so just switched to
'%s'. This fixes some output failure in one of the subversion test.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5026
AFFECTED FILES
hgext/convert/subversion.py
CHANGE DETAILS
diff --git a/hgext/convert/subversion.py b/hgext/convert/subversion.py
--- a/hgext/convert/subversion.py
+++ b/hgext/convert/subversion.py
@@ -1138,7 +1138,7 @@
path = os.path.realpath(path)
if os.path.isdir(os.path.dirname(path)):
if not os.path.exists(os.path.join(path, 'db', 'fs-type')):
- ui.status(_('initializing svn repository %r\n') %
+ ui.status(_("initializing svn repository '%s'\n") %
os.path.basename(path))
commandline(ui, 'svnadmin').run0('create', path)
created = path
@@ -1149,7 +1149,7 @@
wcpath = os.path.join(encoding.getcwd(), os.path.basename(path) +
'-wc')
- ui.status(_('initializing svn working copy %r\n')
+ ui.status(_("initializing svn working copy '%s'\n")
% os.path.basename(wcpath))
self.run0('checkout', path, wcpath)
To: pulkit, #hg-reviewers
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list