D5030: py3: glob some difference between py2 and py3 output

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Sat Oct 13 01:58:55 UTC 2018


pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  On py2, the directory names are under quotes and on py3 they are not and I don't
  know why.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5030

AFFECTED FILES
  contrib/python3-whitelist
  tests/test-clone.t
  tests/test-convert.t

CHANGE DETAILS

diff --git a/tests/test-convert.t b/tests/test-convert.t
--- a/tests/test-convert.t
+++ b/tests/test-convert.t
@@ -446,7 +446,7 @@
   $ chmod 000 bogusdir
 
   $ hg convert a bogusdir
-  abort: Permission denied: 'bogusdir'
+  abort: Permission denied: *bogusdir* (glob)
   [255]
 
 user permissions should succeed
diff --git a/tests/test-clone.t b/tests/test-clone.t
--- a/tests/test-clone.t
+++ b/tests/test-clone.t
@@ -642,15 +642,15 @@
   $ mkdir a
   $ chmod 000 a
   $ hg clone a b
-  abort: Permission denied: '$TESTTMP/fail/a/.hg'
+  abort: Permission denied: *$TESTTMP/fail/a/.hg* (glob)
   [255]
 
 Inaccessible destination
 
   $ hg init b
   $ cd b
   $ hg clone . ../a
-  abort: Permission denied: '../a'
+  abort: Permission denied: *../a* (glob)
   [255]
   $ cd ..
   $ chmod 700 a
@@ -665,7 +665,7 @@
 
   $ mkfifo a
   $ hg clone a b
-  abort: $ENOTDIR$: '$TESTTMP/fail/a/.hg'
+  abort: $ENOTDIR$: *$TESTTMP/fail/a/.hg* (glob)
   [255]
   $ rm a
 
diff --git a/contrib/python3-whitelist b/contrib/python3-whitelist
--- a/contrib/python3-whitelist
+++ b/contrib/python3-whitelist
@@ -69,6 +69,7 @@
 test-clone-r.t
 test-clone-uncompressed.t
 test-clone-update-order.t
+test-clone.t
 test-clonebundles.t
 test-commit-amend.t
 test-commit-interactive.t



To: pulkit, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list