D5090: wireproto: fix incorrect function name in docstring

sheehan (Connor Sheehan) phabricator at mercurial-scm.org
Sun Oct 14 07:43:45 UTC 2018


sheehan created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The docstring for `iwireprotocolcommandcacher` references
  an `onoutputfinished` method. The actual name of the function
  is `onfinished`.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5090

AFFECTED FILES
  mercurial/repository.py

CHANGE DETAILS

diff --git a/mercurial/repository.py b/mercurial/repository.py
--- a/mercurial/repository.py
+++ b/mercurial/repository.py
@@ -1713,7 +1713,7 @@
     8. The command function is invoked.
     9. ``onobject()`` is called for each object emitted by the command
        function.
-    10. After the final object is seen, ``onoutputfinished()`` is called.
+    10. After the final object is seen, ``onfinished()`` is called.
     11. ``__exit__`` is called to signal the end of use of the instance.
 
     Cache *key* derivation can be influenced by the instance.
@@ -1748,7 +1748,7 @@
 
     Implementations could also choose to not emit objects - instead locally
     buffering objects or their encoded representation. They could then emit
-    a single "coalesced" object when ``onoutputfinished()`` is called. In
+    a single "coalesced" object when ``onfinished()`` is called. In
     this way, the implementation would function as a filtering layer of
     sorts.
 



To: sheehan, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list