D5107: localrepo: ensure we properly %-format ints vs strings in exception throw

yuja (Yuya Nishihara) phabricator at mercurial-scm.org
Mon Oct 15 11:18:38 EDT 2018


yuja added a comment.


  >       raise error.FilteredRepoLookupError(_("filtered revision '%s'")
  >                                           % pycompat.bytestr(changeid))
  >   except (IndexError, LookupError):
  > 
  > +            if isinstance(changeid, int):
  >  +                raise error.RepoLookupError(
  >  +                    _("unknown revision '%d'") % changeid)
  > 
  >   raise error.RepoLookupError(_("unknown revision '%s'") % changeid)
  
  Use `pycompat.bytestr(changeid)`? It's worked around as such just a few lines
  above.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5107

To: durin42, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list