D5105: style: drop requirement to only use single lines between top-level objects

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Tue Oct 16 03:52:23 EDT 2018


indygreg accepted this revision.
indygreg added a comment.
This revision is now accepted and ready to land.


  At the 4.8 sprint, we agreed to repo mass rewriting with style that is more PEP-8 like. The tentative plan is to use black, which is very opinionated and doesn't give us much room for style flexibility. But regardless if we do that, I distinctly remember us saying we wanted to adopt double newline between module elements, allowing `_` in names, and using CamelCase for class names. The former would be added automatically by black. The latter 2 would lead to inconsistent style in the long term, which we're OK with.
  
  Since we agreed to allow double newlines and this patch formalizes that policy decision, I'm taking it. (I would also accept patches that removes the bit that complains about new symbols using `_` and uppercase in names.)

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5105

To: mjpieters, #hg-reviewers, durin42, indygreg
Cc: durin42, indygreg, mercurial-devel


More information about the Mercurial-devel mailing list