D4931: narrow: only send the narrowspecs back if ACL in play
indygreg (Gregory Szorc)
phabricator at mercurial-scm.org
Tue Oct 16 15:05:39 EDT 2018
indygreg added a comment.
In https://phab.mercurial-scm.org/D4931#76568, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D4931#76476, @pulkit wrote:
>
> > @martinvonz Looks like this got missed for discussing in sprint, can you have a look at this please? This is important because once we have narrowspecs greater than 255 length and and don't use ellipses, we hit https://bz.mercurial-scm.org/show_bug.cgi?id=5952
>
>
> Maybe we can instead require `experimental.httppostargs` to be on when using narrow?
The problem is the narrow specs are being transported as a bundle2 part parameter and those have a limit of 255 bytes. The narrow spec needs to be transported as a bundle2 part payload, which can be infinite length. (Or not transferred at all.)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D4931
To: pulkit, durin42, martinvonz, #hg-reviewers
Cc: indygreg, mercurial-devel
More information about the Mercurial-devel
mailing list