D5130: lfs: autoload the extension when cloning from repo with lfs enabled

indygreg (Gregory Szorc) phabricator at mercurial-scm.org
Wed Oct 17 08:09:27 EDT 2018


indygreg added a comment.


  > ! In https://phab.mercurial-scm.org/D5130#76736, @mharbison72 wrote:
  >  Will do.  How hard do you think it will be to do the same thing for pull?
  
  I don't think it should be too difficult to implement. But I have possibly controversial opinions about the UI. e.g. I'm not a fan of mutating repo requirements after repo creation without the user's explicit consent. (But not being able to pull from a remote that recently added LFS is a bad experience as well.)
  
  > Also, I need to see if this can be made to work with cloning from a local repo.
  
  I'm **really** not a fan of local / hardlink clones. They are very brittle. When you start throwing extra repo features like LFS into the mix, it becomes even more dangerous. Especially when we start talking about adding modifying `.hg/requires` automatically. The fundamental problem is the hardlink clone is strictly separate but it "inherits" some state from its parent. If we start varying behavior of the two repos, interaction between them can be wonky. In general, for advanced features, we should go through the "hg clone --pull" interface to create a clean break and minimize potential for wonkiness.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5130

To: mharbison72, indygreg, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list