D5137: streamclone: new server config and some API changes for narrow stream clones

Martin von Zweigbergk martinvonz at google.com
Thu Oct 18 09:09:04 EDT 2018


On Thu, Oct 18, 2018, 02:22 pulkit (Pulkit Goyal) <
phabricator at mercurial-scm.org wrote:

> pulkit added a comment.
>
>
>   @martinvonz many thanks for changing things in flight. Any reason why
> https://phab.mercurial-scm.org/D5138 and
> https://phab.mercurial-scm.org/D5139 are not considered during review
> because with them, you won't have to change much things except the config
> knob to experimental.
>

Each patch should pass tests in its own. Otherwise code archeology
(including bisection) will get much harder.

I just got a new computer that's fast enough that i can run tests on each
patch. I had been taking shortcuts before, so if you had sent knowingly
broken patches before, that may have been why I didn't notice :)


> REPOSITORY
>   rHG Mercurial
>
> REVISION DETAIL
>   https://phab.mercurial-scm.org/D5137
>
> To: pulkit, durin42, #hg-reviewers, martinvonz
> Cc: martinvonz, indygreg, mercurial-devel
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20181018/d66718fc/attachment.html>


More information about the Mercurial-devel mailing list