D5161: branchmap: pass changelog into branchmap functions

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Fri Oct 19 13:14:27 EDT 2018


pulkit added inline comments.

INLINE COMMENTS

> branchmap.py:407
>  
> -    def branchinfo(self, rev):
> +    def branchinfo(self, rev, changelog=None):
>          """Return branch name and close flag for rev, using and updating

There is one more call of this function in revset.py:491 which is also inside a for-loop. Doing this same thing there will speed up the branch() revset. If possible, can you have a look before the freeze?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5161

To: indygreg, #hg-reviewers, pulkit
Cc: mercurial-devel


More information about the Mercurial-devel mailing list