D4820: logtoprocess: sends the canonical command name to the subprocess

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Mon Oct 22 09:57:36 EDT 2018


lothiraldan added a comment.


  In https://phab.mercurial-scm.org/D4820#77397, @yuja wrote:
  
  > > +                    # extract the canonical command from the passed opts.
  > >  +                    # we need to pop it up from the opts else the msg will try
  > >  +                    # being formatted using the passed opts.
  >
  > Oops, that's probably a bug. IIUC, `**opts` is just ancillary data, and
  >  the `msg[0]` should always be parameterized by `msg[1:]`. That's how blackbox
  >  works.
  >
  > Can you send a separate patch to fix the issue?
  
  
  Done, I hope the stack was correctly saved because I had to to it through the interface, `phabsend` didn't worked.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4820

To: lothiraldan, #hg-reviewers
Cc: yuja, mercurial-devel


More information about the Mercurial-devel mailing list