D5188: narrow: replace filtering in list comprehension by set operations

[martinvonz (Martin von Zweigbergk)]

martinvonz created this revision.
Herald added a reviewer: durin42.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  I didn't think of this while reviewing the patch.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5188

AFFECTED FILES
  hgext/narrow/narrowcommands.py

CHANGE DETAILS

diff --git a/hgext/narrow/narrowcommands.py b/hgext/narrow/narrowcommands.py
--- a/hgext/narrow/narrowcommands.py
+++ b/hgext/narrow/narrowcommands.py
@@ -400,10 +400,10 @@
 
     # filter the user passed additions and deletions into actual additions and
     # deletions of excludes and includes
-    addedincludes = set([i for i in addedincludes if i not in oldincludes])
-    removedincludes = set([i for i in removedincludes if i in oldincludes])
-    addedexcludes = set([i for i in addedexcludes if i not in oldexcludes])
-    removedexcludes = set([i for i in removedexcludes if i in oldexcludes])
+    addedincludes -= oldincludes
+    removedincludes &= oldincludes
+    addedexcludes -= oldexcludes
+    removedexcludes &= oldexcludes
 
     widening = addedincludes or removedexcludes
     narrowing = removedincludes or addedexcludes



To: martinvonz, durin42, #hg-reviewers
Cc: mercurial-devel