D5193: remotefilelog: drop compat code for "getbundle_shallow" wireprotocol command

pulkit (Pulkit Goyal) phabricator at mercurial-scm.org
Wed Oct 24 15:49:23 UTC 2018


pulkit created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  Doing some annotate on hgexperimental shows that getbundle_shallow used to exist
  in 2013 or before. We don't have any pre-2013 remotefilelog users except Fb
  themselves and I doubt they are going to use in-core remotefilelog. So it's safe
  to remove this.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D5193

AFFECTED FILES
  hgext/remotefilelog/remotefilelogserver.py

CHANGE DETAILS

diff --git a/hgext/remotefilelog/remotefilelogserver.py b/hgext/remotefilelog/remotefilelogserver.py
--- a/hgext/remotefilelog/remotefilelogserver.py
+++ b/hgext/remotefilelog/remotefilelogserver.py
@@ -178,18 +178,6 @@
 
     extensions.wrapfunction(streamclone, '_walkstreamfiles', _walkstreamfiles)
 
-    # We no longer use getbundle_shallow commands, but we must still
-    # support it for migration purposes
-    def getbundleshallow(repo, proto, others):
-        bundlecaps = others.get('bundlecaps', '')
-        bundlecaps = set(bundlecaps.split(','))
-        bundlecaps.add(constants.BUNDLE2_CAPABLITY)
-        others['bundlecaps'] = ','.join(bundlecaps)
-
-        return wireprotov1server.commands["getbundle"][0](repo, proto, others)
-
-    wireprotov1server.commands["getbundle_shallow"] = (getbundleshallow, '*')
-
     # expose remotefilelog capabilities
     def _capabilities(orig, repo, proto):
         caps = orig(repo, proto)



To: pulkit, #hg-reviewers
Cc: mercurial-devel


More information about the Mercurial-devel mailing list