[Bug 6009] New: Traceback when pressing Enter in interactive commit

[mercurial-bugs at mercurial-scm.org]

https://bz.mercurial-scm.org/show_bug.cgi?id=6009

            Bug ID: 6009
           Summary: Traceback when pressing Enter in interactive commit
           Product: Mercurial
           Version: stable branch
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Severity: bug
          Priority: wish
         Component: Mercurial
          Assignee: bugzilla at mercurial-scm.org
          Reporter: zash at zash.se
                CC: mercurial-devel at mercurial-scm.org

$ hg status -q
obsolete feature not enabled but 4809 markers found!  ( evolve disabled to see
if this happens without )
M core/certmanager.lua
M core/moduleapi.lua
M net/server_epoll.lua

$ hg ci -i
obsolete feature not enabled but 4809 markers found!
starting interactive selection

Press Enter, get traceback:

** unknown exception encountered, please report by visiting
** https://mercurial-scm.org/wiki/BugTracker
** Python 2.7.13 (default, Sep 26 2018, 18:42:22) [GCC 6.3.0 20170516]
** Mercurial Distributed SCM (version 4.8rc0)
** Extensions loaded: extdiff, fix, githelp, histedit, journal, purge, rebase,
releasenotes, relink, schemes, shelve, show, strip, transplant
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/mercurial/commandserver.py", line 353,
in _serverequest
    sv.serve()
  File "/usr/lib/python2.7/dist-packages/mercurial/commandserver.py", line 301,
in serve
    while self.serveone():
  File "/usr/lib/python2.7/dist-packages/mercurial/commandserver.py", line 276,
in serveone
    handler(self)
  File "/usr/lib/python2.7/dist-packages/mercurial/chgserver.py", line 487, in
runcommand
    return super(chgcmdserver, self).runcommand()
  File "/usr/lib/python2.7/dist-packages/mercurial/commandserver.py", line 260,
in runcommand
    ret = dispatch.dispatch(req) & 255
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 220, in
dispatch
    ret = _runcatch(req) or 0
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 363, in
_runcatch
    return _callcatch(ui, _runcatchfunc)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 371, in
_callcatch
    return scmutil.callcatch(ui, func)
  File "/usr/lib/python2.7/dist-packages/mercurial/scmutil.py", line 166, in
callcatch
    return func()
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 354, in
_runcatchfunc
    return _dispatch(req)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 994, in
_dispatch
    cmdpats, cmdoptions)
  File "/usr/lib/python2.7/dist-packages/hgext/journal.py", line 90, in
runcommand
    return orig(lui, repo, cmd, fullargs, *args)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 737, in
runcommand
    ret = _runcommand(ui, options, cmd, d)
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 1003, in
_runcommand
    return cmdfunc()
  File "/usr/lib/python2.7/dist-packages/mercurial/dispatch.py", line 991, in
<lambda>
    d = lambda: util.checksignature(func)(ui, *args, **strcmdopt)
  File "/usr/lib/python2.7/dist-packages/mercurial/util.py", line 1644, in
check
    return func(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/mercurial/commands.py", line 1631, in
commit
    return _docommit(ui, repo, *pats, **opts)
  File "/usr/lib/python2.7/dist-packages/mercurial/commands.py", line 1638, in
_docommit
    **opts)
  File "/usr/lib/python2.7/dist-packages/mercurial/cmdutil.py", line 417, in
dorecord
    return commit(ui, repo, recordinwlock, pats, opts)
  File "/usr/lib/python2.7/dist-packages/mercurial/cmdutil.py", line 2398, in
commit
    return commitfunc(ui, repo, message, matcher, opts)
  File "/usr/lib/python2.7/dist-packages/mercurial/cmdutil.py", line 415, in
recordinwlock
    return recordfunc(ui, repo, message, match, opts)
  File "/usr/lib/python2.7/dist-packages/mercurial/cmdutil.py", line 294, in
recordfunc
    chunks, newopts = filterfn(ui, originalchunks)
  File "/usr/lib/python2.7/dist-packages/mercurial/cmdutil.py", line 232, in
recordfilter
    testfile, operation)
  File "/usr/lib/python2.7/dist-packages/mercurial/cmdutil.py", line 213, in
filterchunks
    operation)
  File "/usr/lib/python2.7/dist-packages/mercurial/crecord.py", line 505, in
filterpatch
    ret = chunkselector(ui, uiheaders, operation=operation)
  File "/usr/lib/python2.7/dist-packages/mercurial/crecord.py", line 536, in
chunkselector
    curses.wrapper(chunkselector.main)
  File "/usr/lib/python2.7/curses/wrapper.py", line 43, in wrapper
    return func(stdscr, *args, **kwds)
  File "/usr/lib/python2.7/dist-packages/mercurial/crecord.py", line 1739, in
main
    return self._main(stdscr)
  File "/usr/lib/python2.7/dist-packages/mercurial/crecord.py", line 1798, in
_main
    if self.handlekeypressed(keypressed):
  File "/usr/lib/python2.7/dist-packages/mercurial/crecord.py", line 1710, in
handlekeypressed
    self.nextsametype()
  File "/usr/lib/python2.7/dist-packages/mercurial/crecord.py", line 728, in
nextsametype
    if parent.folded:
AttributeError: 'NoneType' object has no attribute 'folded'


Does not happen when pressing Space

-- 
You are receiving this mail because:
You are on the CC list for the bug.